diff --git a/cmd/nfsplugin/main.go b/cmd/nfsplugin/main.go index d0b99985..876ca842 100644 --- a/cmd/nfsplugin/main.go +++ b/cmd/nfsplugin/main.go @@ -62,6 +62,6 @@ func handle() { parsedPerm = &permu32 } - d := nfs.NewNFSdriver(*nodeID, *driverName, *endpoint, parsedPerm) + d := nfs.NewDriver(*nodeID, *driverName, *endpoint, parsedPerm) d.Run(false) } diff --git a/hack/release-image.sh b/hack/release-image.sh index 833d5ba6..faf2c09d 100755 --- a/hack/release-image.sh +++ b/hack/release-image.sh @@ -28,7 +28,7 @@ export IMAGENAME=public/k8s/csi/nfs-csi export CI=1 export PUBLISH=1 az acr login --name $REGISTRY_NAME -make container push push-latest +make && make container push push-latest echo "sleep 60s ..." sleep 60 diff --git a/pkg/nfs/controllerserver_test.go b/pkg/nfs/controllerserver_test.go index 3c095420..66c1c15d 100644 --- a/pkg/nfs/controllerserver_test.go +++ b/pkg/nfs/controllerserver_test.go @@ -49,7 +49,7 @@ var ( func initTestController(t *testing.T) *ControllerServer { var perm *uint32 mounter := &mount.FakeMounter{MountPoints: []mount.MountPoint{}} - driver := NewNFSdriver("", "", "", perm) + driver := NewDriver("", "", "", perm) driver.ns = NewNodeServer(driver, mounter) cs := NewControllerServer(driver) cs.workingMountDir = "/tmp" diff --git a/pkg/nfs/nfs.go b/pkg/nfs/nfs.go index 985fcaef..b728eb41 100644 --- a/pkg/nfs/nfs.go +++ b/pkg/nfs/nfs.go @@ -52,16 +52,12 @@ const ( paramShare = "share" ) -var ( - version = "3.0.0" -) - -func NewNFSdriver(nodeID, driverName, endpoint string, perm *uint32) *Driver { - klog.Infof("Driver: %v version: %v", driverName, version) +func NewDriver(nodeID, driverName, endpoint string, perm *uint32) *Driver { + klog.V(2).Infof("Driver: %v version: %v", driverName, driverVersion) n := &Driver{ name: driverName, - version: version, + version: driverVersion, nodeID: nodeID, endpoint: endpoint, cap: map[csi.VolumeCapability_AccessMode_Mode]bool{}, @@ -79,9 +75,6 @@ func NewNFSdriver(nodeID, driverName, endpoint string, perm *uint32) *Driver { } n.AddVolumeCapabilityAccessModes(vcam) - // NFS plugin does not support ControllerServiceCapability now. - // If support is added, it should set to appropriate - // ControllerServiceCapability RPC types. n.AddControllerServiceCapabilities([]csi.ControllerServiceCapability_RPC_Type{ csi.ControllerServiceCapability_RPC_CREATE_DELETE_VOLUME, csi.ControllerServiceCapability_RPC_SINGLE_NODE_MULTI_WRITER, diff --git a/pkg/nfs/nfs_test.go b/pkg/nfs/nfs_test.go index f01f9bf4..a7fe9d4e 100644 --- a/pkg/nfs/nfs_test.go +++ b/pkg/nfs/nfs_test.go @@ -45,7 +45,7 @@ func NewEmptyDriver(emptyField string) *Driver { case "name": d = &Driver{ name: "", - version: version, + version: driverVersion, nodeID: fakeNodeID, cap: map[csi.VolumeCapability_AccessMode_Mode]bool{}, perm: perm, @@ -53,7 +53,7 @@ func NewEmptyDriver(emptyField string) *Driver { default: d = &Driver{ name: DefaultDriverName, - version: version, + version: driverVersion, nodeID: fakeNodeID, cap: map[csi.VolumeCapability_AccessMode_Mode]bool{}, perm: perm, diff --git a/test/e2e/e2e_suite_test.go b/test/e2e/e2e_suite_test.go index 7444e8ad..a3b69328 100644 --- a/test/e2e/e2e_suite_test.go +++ b/test/e2e/e2e_suite_test.go @@ -68,7 +68,7 @@ var _ = ginkgo.BeforeSuite(func() { handleFlags() framework.AfterReadingAllFlags(&framework.TestContext) - nfsDriver = nfs.NewNFSdriver(nodeID, nfs.DefaultDriverName, fmt.Sprintf("unix:///tmp/csi-%s.sock", uuid.NewUUID().String()), perm) + nfsDriver = nfs.NewDriver(nodeID, nfs.DefaultDriverName, fmt.Sprintf("unix:///tmp/csi-%s.sock", uuid.NewUUID().String()), perm) controllerServer = nfs.NewControllerServer(nfsDriver) // install nfs server