kubernetes-csi/csi-driver-nfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #483 from andyzhangx/disable-snapshot-controller-install

Browse Source 
feat: disable snapshot controller install in helm chart by default
This commit is contained in:
Andy Zhang 2023-07-17 12:23:30 +08:00 committed by GitHub
commit 4bfd786ee6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@ -42,7 +42,7 @@ REGISTRY_NAME ?= $(shell echo $(REGISTRY) | sed "s/.azurecr.io//g")
IMAGE_TAG = $(REGISTRY)/$(IMAGENAME):$(IMAGE_VERSION) IMAGE_TAG = $(REGISTRY)/$(IMAGENAME):$(IMAGE_VERSION)
IMAGE_TAG_LATEST = $(REGISTRY)/$(IMAGENAME):latest IMAGE_TAG_LATEST = $(REGISTRY)/$(IMAGENAME):latest
E2E_HELM_OPTIONS ?= --set image.nfs.repository=$(REGISTRY)/$(IMAGENAME) --set image.nfs.tag=$(IMAGE_VERSION) --set image.nfs.pullPolicy=Always --set feature.enableInlineVolume=true E2E_HELM_OPTIONS ?= --set image.nfs.repository=$(REGISTRY)/$(IMAGENAME) --set image.nfs.tag=$(IMAGE_VERSION) --set image.nfs.pullPolicy=Always --set feature.enableInlineVolume=true --set externalSnapshotter.enabled=true
E2E_HELM_OPTIONS += ${EXTRA_HELM_OPTIONS} E2E_HELM_OPTIONS += ${EXTRA_HELM_OPTIONS}
# Output type of docker buildx build # Output type of docker buildx build

8
charts/README.md
View File

@ -4,6 +4,7 @@
- [install Helm](https://helm.sh/docs/intro/quickstart/#install-helm) - [install Helm](https://helm.sh/docs/intro/quickstart/#install-helm)
### Tips ### Tips
- install csi snapshot controller: `--set externalSnapshotter.enabled=true`
- run controller on control plane node: `--set controller.runOnControlPlane=true` - run controller on control plane node: `--set controller.runOnControlPlane=true`
- set replica of controller as `2`: `--set controller.replicas=2` - set replica of controller as `2`: `--set controller.replicas=2`
- Microk8s based kubernetes recommended settings: - Microk8s based kubernetes recommended settings:
@ -98,6 +99,13 @@ The following table lists the configurable parameters of the latest NFS CSI Driv
| `node.resources.nfs.limits.memory` | csi-driver-nfs memory limits | 300Mi | | `node.resources.nfs.limits.memory` | csi-driver-nfs memory limits | 300Mi |
| `node.resources.nfs.requests.cpu` | csi-driver-nfs cpu requests limits | 10m | | `node.resources.nfs.requests.cpu` | csi-driver-nfs cpu requests limits | 10m |
| `node.resources.nfs.requests.memory` | csi-driver-nfs memory requests limits | 20Mi | | `node.resources.nfs.requests.memory` | csi-driver-nfs memory requests limits | 20Mi |
| `externalSnapshotter.enabled` | enable snapshot-controller | `false`
| `externalSnapshotter.name` | name of snapshot-controller | `snapshot-controller`
| `externalSnapshotter.controller.replicas` | replica number of snapshot-controller | 1
| `externalSnapshotter.resources.limits.memory` | snapshot-controller memory limits | 300Mi |
| `externalSnapshotter.resources.requests.cpu` | snapshot-controller cpu requests limits | 10m |
| `externalSnapshotter.resources.requests.memory` | snapshot-controller memory requests limits | 20Mi |
## troubleshooting ## troubleshooting
- Add `--wait -v=5 --debug` in `helm install` command to get detailed error - Add `--wait -v=5 --debug` in `helm install` command to get detailed error

BIN
charts/latest/csi-driver-nfs-v0.0.0.tgz
View File

Binary file not shown.

2
charts/latest/csi-driver-nfs/values.yaml
View File

@ -125,7 +125,7 @@ node:
memory: 20Mi memory: 20Mi
externalSnapshotter: externalSnapshotter:
enabled: true enabled: false
name: snapshot-controller name: snapshot-controller
controller: controller:
replicas: 1 replicas: 1