13dabe6edf
### Motivation
if you deploy pulsar using the helm chart and disable monitoring with
```
extras:
dashboard: no
```
but you have the ingress of the dashboard set to true
```
dashboard:
ingress:
enabled: true
```
the helm chart will create an ingress that points to a non-existing service because the dashboard itself was not deployed.
### Modifications
I've added the same check that is already in place in dashboard-service and dashboard-deployment
### Verifying this change
I dont know of any automated tests, i tested it manually. In the end it's the same "if" that is already in place in dashboard-service and dashboard-deployment
### Does this pull request potentially affect one of the following parts:
Affects deployment via helm chart. An unwanted ingress object is suppressed.
### Documentation
no documentation need
56 lines
3.0 KiB
YAML
56 lines
3.0 KiB
YAML
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
{{- if .Values.extra.dashboard }}
|
|
{{- if .Values.dashboard.ingress.enabled }}
|
|
apiVersion: extensions/v1beta1
|
|
kind: Ingress
|
|
metadata:
|
|
labels:
|
|
app: {{ template "pulsar.name" . }}
|
|
chart: {{ template "pulsar.chart" . }}
|
|
release: {{ .Release.Name }}
|
|
heritage: {{ .Release.Service }}
|
|
cluster: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
|
|
annotations:
|
|
{{- with .Values.dashboard.ingress.annotations }}
|
|
{{ toYaml . | indent 4 }}
|
|
{{- end }}
|
|
name: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
|
|
namespace: {{ .Values.namespace }}
|
|
spec:
|
|
{{- if .Values.dashboard.ingress.tls.enabled }}
|
|
tls:
|
|
- hosts:
|
|
- {{ .Values.dashboard.ingress.hostname }}
|
|
{{- with .Values.dashboard.ingress.tls.secretName }}
|
|
secretName: {{ . }}
|
|
{{- end }}
|
|
{{- end }}
|
|
rules:
|
|
- host: {{ required "Dashboard ingress hostname not provided" .Values.dashboard.ingress.hostname }}
|
|
http:
|
|
paths:
|
|
- path: {{ .Values.dashboard.ingress.path }}
|
|
backend:
|
|
serviceName: "{{ template "pulsar.fullname" . }}-{{ .Values.dashboard.component }}"
|
|
servicePort: {{ .Values.dashboard.ingress.port }}
|
|
{{- end }}
|
|
{{- end }}
|