6c9856a1af
It remains possible to override the current release namespace by setting the `namespace` value though this may lead to having the helm metadata and the pulsar components in different namespaces Fixes #66 ### Motivation Trying to deploy the chart in a namespace using the usual helm pattern fails for example ``` kubectl create ns pulsartest helm upgrade --install pulsar -n pulsartest apache/pulsar Error: namespaces "pulsar" not found ``` fixing that while keeping the helm metadata and the deployed objects in the same namespace requires declaring the namespace twice ``` kubectl create ns pulsartest helm upgrade --install pulsar -n pulsartest apache/pulsar --set namespace=pulsartest Error: namespaces "pulsar" not found ``` This is needlessly confusing for newcomers who follow the helm documentation and is contrary to helm best practices. ### Modifications I changed the chart to use the context namespace `.Release.Namespace` by default while preserving the ability to override that by explicitly providing a namespace on the commande line, with the this modification both examples behave as expected ### Verifying this change - [x] Make sure that the change passes the CI checks.
79 lines
3.5 KiB
YAML
79 lines
3.5 KiB
YAML
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
{{- if .Values.initialize }}
|
|
{{- if .Values.components.bookkeeper }}
|
|
apiVersion: batch/v1
|
|
kind: Job
|
|
metadata:
|
|
name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}-init"
|
|
namespace: {{ template "pulsar.namespace" . }}
|
|
labels:
|
|
{{- include "pulsar.standardLabels" . | nindent 4 }}
|
|
component: "{{ .Values.bookkeeper.component }}-init"
|
|
spec:
|
|
template:
|
|
spec:
|
|
initContainers:
|
|
- name: wait-zookeeper-ready
|
|
image: "{{ .Values.images.bookie.repository }}:{{ .Values.images.bookie.tag }}"
|
|
imagePullPolicy: {{ .Values.images.bookie.pullPolicy }}
|
|
command: ["sh", "-c"]
|
|
args:
|
|
- >-
|
|
{{- if $zk:=.Values.pulsar_metadata.userProvidedZookeepers }}
|
|
until bin/pulsar zookeeper-shell -server {{ $zk }} ls {{ or .Values.metadataPrefix "/" }}; do
|
|
echo "user provided zookeepers {{ $zk }} are unreachable... check in 3 seconds ..." && sleep 3;
|
|
done;
|
|
{{ else }}
|
|
until nslookup {{ template "pulsar.fullname" . }}-{{ .Values.zookeeper.component }}-{{ add (.Values.zookeeper.replicaCount | int) -1 }}.{{ template "pulsar.fullname" . }}-{{ .Values.zookeeper.component }}.{{ template "pulsar.namespace" . }}; do
|
|
sleep 3;
|
|
done;
|
|
{{- end}}
|
|
containers:
|
|
- name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}-init"
|
|
image: "{{ .Values.images.bookie.repository }}:{{ .Values.images.bookie.tag }}"
|
|
imagePullPolicy: {{ .Values.images.bookie.pullPolicy }}
|
|
{{- if .Values.bookkeeper.metadata.resources }}
|
|
resources:
|
|
{{ toYaml .Values.bookkeeper.metadata.resources | indent 10 }}
|
|
{{- end }}
|
|
command: ["sh", "-c"]
|
|
args:
|
|
- >
|
|
bin/apply-config-from-env.py conf/bookkeeper.conf;
|
|
{{- include "pulsar.toolset.zookeeper.tls.settings" . | nindent 12 }}
|
|
if bin/bookkeeper shell whatisinstanceid; then
|
|
echo "bookkeeper cluster already initialized";
|
|
else
|
|
{{- if not (eq .Values.metadataPrefix "") }}
|
|
bin/bookkeeper org.apache.zookeeper.ZooKeeperMain -server {{ template "pulsar.fullname" . }}-{{ .Values.zookeeper.component }} create {{ .Values.metadataPrefix }} 'created for pulsar cluster "{{ template "pulsar.cluster.name" . }}"' || yes &&
|
|
{{- end }}
|
|
bin/bookkeeper shell initnewcluster;
|
|
fi
|
|
envFrom:
|
|
- configMapRef:
|
|
name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}"
|
|
volumeMounts:
|
|
{{- include "pulsar.toolset.certs.volumeMounts" . | nindent 8 }}
|
|
volumes:
|
|
{{- include "pulsar.toolset.certs.volumes" . | nindent 6 }}
|
|
restartPolicy: Never
|
|
{{- end }}
|
|
{{- end }}
|