changed publishNotReadyAddresses to (#64)

### Motivation

* ```publishNotReadyAddresses``` is a service spec and not a service annotation. This is mentioned in the K8s API docs at https://v1-17.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#servicespec-v1-core

### Modifications

* Modified ```publishNotReadyAddresses``` from annotation to service spec

### Verifying this change

- [x] Make sure that the change passes the CI checks.
This commit is contained in:
Naveen Ramanathan 2020-10-15 16:12:13 +05:30 committed by GitHub
parent bf5db574d1
commit fb4c44f449
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions

View File

@ -26,8 +26,10 @@ metadata:
labels: labels:
{{- include "pulsar.standardLabels" . | nindent 4 }} {{- include "pulsar.standardLabels" . | nindent 4 }}
component: {{ .Values.bookkeeper.component }} component: {{ .Values.bookkeeper.component }}
{{- if .Values.bookkeeper.service.annotations }}
annotations: annotations:
{{ toYaml .Values.bookkeeper.service.annotations | indent 4 }} {{ toYaml .Values.bookkeeper.service.annotations | indent 4 }}
{{- end }}
spec: spec:
ports: ports:
- name: bookie - name: bookie
@ -38,4 +40,7 @@ spec:
selector: selector:
{{- include "pulsar.matchLabels" . | nindent 4 }} {{- include "pulsar.matchLabels" . | nindent 4 }}
component: {{ .Values.bookkeeper.component }} component: {{ .Values.bookkeeper.component }}
{{- if .Values.bookkeeper.service.spec }}
{{- toYaml .Values.bookkeeper.service.spec | trim | nindent 2 }}
{{- end }}
{{- end }} {{- end }}

View File

@ -489,8 +489,8 @@ bookkeeper:
## templates/bookkeeper-service.yaml ## templates/bookkeeper-service.yaml
## ##
service: service:
annotations: spec:
publishNotReadyAddresses: "true" publishNotReadyAddresses: true
## Bookkeeper PodDisruptionBudget ## Bookkeeper PodDisruptionBudget
## templates/bookkeeper-pdb.yaml ## templates/bookkeeper-pdb.yaml
## ##