apache/pulsar-helm-chart
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Alphabetically sort list of super users (#291)

Browse Source 
Fixes #288 

### Motivation

When specifying multiple roles in `.Values.auth.superUsers` the values are converted to a comma-separated list by piping the dict through `values` and `join` in helm templating, `values` however doesn't guarantee that the order of elements will be the same every time. Therefor it recommends also passing it through `sortAlpha` to sort the list alphabetically.

This is a problematic when `.Values.broker.restartPodsOnConfigMapChange` is enabled because the checksum of the configmap changes every time the list's order is changed, resulting in the statefulsets rolling out a new version of the pods.

### Modifications

Pass list through `sortAlpha`.

### Verifying this change

- [x] Make sure that the change passes the CI checks.
This commit is contained in:
Arnar 2022-10-17 21:36:22 +02:00 committed by GitHub
parent 20c55022df
commit f3ba780ab5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
charts/pulsar/templates/broker-configmap.yaml
View File

@ -110,7 +110,7 @@ data:
authenticationEnabled: "true" authenticationEnabled: "true"
{{- if .Values.auth.authorization.enabled }} {{- if .Values.auth.authorization.enabled }}
authorizationEnabled: "true" authorizationEnabled: "true"
superUserRoles: {{ .Values.auth.superUsers | values | join "," }} superUserRoles: {{ .Values.auth.superUsers | values | sortAlpha | join "," }}
{{- end }} {{- end }}
{{- if eq .Values.auth.authentication.provider "jwt" }} {{- if eq .Values.auth.authentication.provider "jwt" }}
# token authentication configuration # token authentication configuration

2
charts/pulsar/templates/proxy-configmap.yaml
View File

@ -64,7 +64,7 @@ data:
# disable authorization on proxy and forward authorization credentials to broker # disable authorization on proxy and forward authorization credentials to broker
authorizationEnabled: "false" authorizationEnabled: "false"
forwardAuthorizationCredentials: "true" forwardAuthorizationCredentials: "true"
superUserRoles: {{ .Values.auth.superUsers | values | join "," }} superUserRoles: {{ .Values.auth.superUsers | values | sortAlpha | join "," }}
{{- end }} {{- end }}
{{- if eq .Values.auth.authentication.provider "jwt" }} {{- if eq .Values.auth.authentication.provider "jwt" }}
# token authentication configuration # token authentication configuration