From cad175d8e6957e505251d09cb79392a2bf840f48 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= <dunglas@gmail.com>
Date: Sat, 11 Jan 2020 14:48:44 +0100
Subject: [PATCH] Fix typos in Helm chart and sync values-mini with values
 (#6009)

### Motivation

Fix typos and sync values-mini with values

### Modifications

Comments only.
---
 pulsar/values-mini.yaml | 92 +++++++++++++++++++++++++++++++++--------
 1 file changed, 74 insertions(+), 18 deletions(-)

diff --git a/pulsar/values-mini.yaml b/pulsar/values-mini.yaml
index 207b4cd..deca819 100644
--- a/pulsar/values-mini.yaml
+++ b/pulsar/values-mini.yaml
@@ -21,9 +21,9 @@
 namespace: pulsar
 namespaceCreate: yes
 
-## If persistence is enabled, components that has state will
+## If persistence is enabled, components that have state will
 ## be deployed with PersistentVolumeClaims, otherwise, for test
-## purposes, they will be deployed with emptDir
+## purposes, they will be deployed with emptyDir
 persistence: no
 
 ## If prometheus_persistence is enabled, prometheus will be deployed
@@ -80,6 +80,17 @@ zookeeper:
     data:
       name: data
       size: 2Gi
+      ## If you already have an existent storage class and want to reuse it, you can specify its name with the option below
+      ##
+      # storageClassName: existent-storage-class
+      #
+      ## Instead if you want to create a new storage class define it below
+      ## If left undefined no storage class will be defined along with PVC
+      ##
+      # storageClass:
+        # type: pd-ssd
+        # fsType: xfs
+        # provisioner: kubernetes.io/gce-pd
   ## Zookeeper configmap
   ## templates/zookeeper-configmap.yaml
   ##
@@ -107,8 +118,8 @@ zookeeper:
     maxUnavailable: 1
 
 ## Pulsar Zookeeper metadata. The metadata will be deployed as
-## soon as the las zookeeper node is reachable. The deployment
-## of other components that depends o zookeeper, such as the
+## soon as the last zookeeper node is reachable. The deployment
+## of other components that depends on zookeeper, such as the
 ## bookkeeper nodes, broker nodes, etc will only start to be
 ## deployed when the zookeeper cluster is ready and with the
 ## metadata deployed
@@ -139,9 +150,31 @@ bookkeeper:
     journal:
       name: journal
       size: 5Gi
+      ## If you already have an existent storage class and want to reuse it, you can specify its name with the option below
+      ##
+      # storageClassName: existent-storage-class
+      #
+      ## Instead if you want to create a new storage class define it below
+      ## If left undefined no storage class will be defined along with PVC
+      ##
+      # storageClass:
+        # type: pd-ssd
+        # fsType: xfs
+        # provisioner: kubernetes.io/gce-pd
     ledgers:
       name: ledgers
       size: 5Gi
+      ## If you already have an existent storage class and want to reuse it, you can specify its name with the option below
+      ##
+      # storageClassName: existent-storage-class
+      #
+      ## Instead if you want to create a new storage class define it below
+      ## If left undefined no storage class will be defined along with PVC
+      ##
+      # storageClass:
+        # type: pd-ssd
+        # fsType: xfs
+        # provisioner: kubernetes.io/gce-pd
   ## Bookkeeper configmap
   ## templates/bookkeeper-configmap.yaml
   ##
@@ -290,14 +323,14 @@ dashboard:
   annotations: {}
   tolarations: []
   gracePeriod: 0
-  resources:
-    requests:
-      memory: 64Mi
-      cpu: 0.1
   image:
     repository: apachepulsar/pulsar-dashboard
     tag: latest
     pullPolicy: IfNotPresent
+    resources:
+      requests:
+        memory: 64Mi
+        cpu: 0.1
   ## Dashboard service
   ## templates/dashboard-service.yaml
   ##
@@ -308,6 +341,18 @@ dashboard:
       port: 80
   ingress:
     enabled: false
+    annotations: {}
+    tls:
+      enabled: false
+
+      ## Optional. Leave it blank if your Ingress Controller can provide a default certificate.
+      secretName: ""
+    
+    ## Required if ingress is enabled
+    hostname: ""
+    path: "/"
+    port: 80
+
 
 ## Pulsar Extra: Bastion
 ## templates/bastion-deployment.yaml
@@ -341,19 +386,30 @@ prometheus:
   annotations: {}
   tolarations: []
   gracePeriod: 0
-  resources:
-    requests:
-      memory: 64Mi
-      cpu: 0.1
   image:
     repository: prom/prometheus
     tag: v1.6.3
     pullPolicy: IfNotPresent
+    resources:
+      requests:
+        memory: 64Mi
+        cpu: 0.1  
   volumes:
     data:
       name: data
       size: 2Gi
-  ## Prometheus service
+      ## If you already have an existent storage class and want to reuse it, you can specify its name with the option below
+      ##
+      # storageClassName: existent-storage-class
+      #
+      ## Instead if you want to create a new storage class define it below
+      ## If left undefined no storage class will be defined along with PVC
+      ##
+      # storageClass:
+        # type: pd-standard
+        # fsType: xfs
+        # provisioner: kubernetes.io/gce-pd
+      ## Prometheus service
   ## templates/prometheus-service.yaml
   ##
   service:
@@ -373,15 +429,15 @@ grafana:
   annotations: {}
   tolarations: []
   gracePeriod: 0
-  resources:
-    requests:
-      memory: 64Mi
-      cpu: 0.1
   image:
     repository: apachepulsar/pulsar-grafana
     tag: latest
     pullPolicy: IfNotPresent
-  ## Grafana service
+    resources:
+      requests:
+        memory: 64Mi
+        cpu: 0.1
+      ## Grafana service
   ## templates/grafana-service.yaml
   ##
   service: