apache/pulsar-helm-chart
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make proxy httpNumThreads configurable (#251)

Browse Source 
Fixes https://github.com/apache/pulsar-helm-chart/issues/250

### Motivation

`httpNumThreads` is hardcoded to 8 in `charts/pulsar/templates/proxy-configmap.yaml`
When trying to override in `values.yaml` by using `proxy.configData.httpNumThreads` we get an error because the keys get duplicated.
This happens because `{{ toYaml .Values.proxy.configData | indent 2 }}` doesn't deduplicate the keys and there is no other way to set `httpNumThreads`

### Modifications

Removing the key from charts/pulsar/templates/proxy-configmap.yaml and adding it to the values yaml solves the problem.

### Verifying this change

- [x] Make sure that the change passes the CI checks.
This commit is contained in:
Filipe Caixeta 2022-06-26 01:57:30 -03:00 committed by GitHub
parent 6afab51bad
commit c05f659ff4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
charts/pulsar/templates/proxy-configmap.yaml
View File

@ -28,7 +28,6 @@ metadata:
component: {{ .Values.proxy.component }} component: {{ .Values.proxy.component }}
data: data:
clusterName: {{ template "pulsar.cluster.name" . }} clusterName: {{ template "pulsar.cluster.name" . }}
httpNumThreads: "8"
statusFilePath: "{{ template "pulsar.home" . }}/status" statusFilePath: "{{ template "pulsar.home" . }}/status"
# prometheus needs to access /metrics endpoint # prometheus needs to access /metrics endpoint
webServicePort: "{{ .Values.proxy.ports.http }}" webServicePort: "{{ .Values.proxy.ports.http }}"

1
charts/pulsar/values.yaml
View File

@ -889,6 +889,7 @@ proxy:
-XX:-ResizePLAB -XX:-ResizePLAB
-XX:+ExitOnOutOfMemoryError -XX:+ExitOnOutOfMemoryError
-XX:+PerfDisableSharedMem -XX:+PerfDisableSharedMem
httpNumThreads: "8"
## Add a custom command to the start up process of the proxy pods (e.g. update-ca-certificates, jvm commands, etc) ## Add a custom command to the start up process of the proxy pods (e.g. update-ca-certificates, jvm commands, etc)
additionalCommand: additionalCommand:
## Proxy service ## Proxy service