apache/pulsar-helm-chart
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Issue-5958][helm]: Fixing templates for helm deployment (#6148)

Browse Source 
Motivation:
Fixes #5958: 

The following error appears when trying to deploy Pulsar using helm and values-mini.yaml: 

```unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Deployment.spec.template.spec.containers[0]): unknown field "requests" in io.k8s.api.core.v1.Container``` 

Cause:
Mistake in the `pulsar-manager-deployment.yaml` deployment file:

First line **63** should be:
`{{- if .Values.pulsar_manager.resources }}` and it is currently `{{- if .Values.grafana.resources }}`

There is also a mistake at line **65**:
`{{ toYaml .Values.grafana.resources | indent 10 }}` should be `{{ toYaml .Values.pulsar_manager.resources | indent 12 }}`

Modifications:
Changed values in `values.yaml` and `templates/pulsar-manager-deployment.yaml`

Test:
Deploy the application into a kubernetes local cluster with
`helm install pulsar-cluster --values pulsar/values-mini.yaml pulsar`

AND

`helm install pulsar-cluster --values pulsar/values.yaml pulsar`

Documentation:
Does this pull request introduce a new feature? - **No**
This commit is contained in:
roman-popenov 2020-02-01 02:56:09 -05:00 committed by GitHub
parent 56e0d05e25
commit 97ed16d2c6
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pulsar/templates/pulsar-manager-deployment.yaml
View File

@ -60,9 +60,9 @@ spec:
- name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}" - name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}"
image: "{{ .Values.pulsar_manager.image.repository }}:{{ .Values.pulsar_manager.image.tag }}" image: "{{ .Values.pulsar_manager.image.repository }}:{{ .Values.pulsar_manager.image.tag }}"
imagePullPolicy: {{ .Values.pulsar_manager.image.pullPolicy }} imagePullPolicy: {{ .Values.pulsar_manager.image.pullPolicy }}
{{- if .Values.grafana.resources }} {{- if .Values.pulsar_manager.resources }}
resources: resources:
{{ toYaml .Values.pulsar_manager.resources | indent 10 }} {{ toYaml .Values.pulsar_manager.resources | indent 12 }}
{{- end }} {{- end }}
ports: ports:
- containerPort: 9527 - containerPort: 9527

8
pulsar/values.yaml
View File

@ -434,10 +434,10 @@ grafana:
repository: apachepulsar/pulsar-grafana repository: apachepulsar/pulsar-grafana
tag: latest tag: latest
pullPolicy: IfNotPresent pullPolicy: IfNotPresent
# resources: resources:
# requests: requests:
# memory: 4Gi memory: 4Gi
# cpu: 1 cpu: 1
## Grafana service ## Grafana service
## templates/grafana-service.yaml ## templates/grafana-service.yaml
## ##