Add Support for imagePullSecrets (#140)

Fixes #125

### Motivation

The default images in the values.yaml are in docker hub. This PR allows us to provide image pull secrets for the containers which will allow us to get around Docker Hub's rate limiting if the nodes are not logged into Docker Hub.

### Modifications

Added a new template to generate `imagePullSecrets`, and included them in the deployments and statefulsets. This will only add them if they are specified under `images.imagePullSecrets`

### Verifying this change

- [] Make sure that the change passes the CI checks.

charts/pulsar/templates/_helpers.tpl

@@ -84,3 +84,15 @@ Create the match labels.
 app: {{ template "pulsar.name" . }}
 release: {{ .Release.Name }}
 {{- end }}
+
+{{/*
+Create ImagePullSecrets
+*/}}
+{{- define "pulsar.imagePullSecrets" -}}
+{{- if .Values.images.imagePullSecrets -}}
+imagePullSecrets:
+{{- range .Values.images.imagePullSecrets }}
+- name: {{ . }}
+{{- end }}
+{{- end -}}
+{{- end }}

charts/pulsar/templates/autorecovery-statefulset.yaml

@@ -150,5 +150,6 @@ spec:
         {{- include "pulsar.autorecovery.certs.volumeMounts" . | nindent 8 }}
       volumes:
       {{- include "pulsar.autorecovery.certs.volumes" . | nindent 6 }}
+      {{- include "pulsar.imagePullSecrets" . | nindent 6}}
 {{- end }}
 

charts/pulsar/templates/bookkeeper-statefulset.yaml

@@ -196,6 +196,7 @@ spec:
         emptyDir: {}
       {{- end }}
       {{- include "pulsar.bookkeeper.certs.volumes" . | nindent 6 }}
+      {{- include "pulsar.imagePullSecrets" . | nindent 6}}
 {{- if and (and .Values.persistence .Values.volumes.persistence) .Values.bookkeeper.volumes.persistence}}
   volumeClaimTemplates:
   {{- if .Values.bookkeeper.volumes.useSingleCommonVolume }}

charts/pulsar/templates/broker-statefulset.yaml

@@ -268,4 +268,5 @@ spec:
       {{- end}}
       {{- end}}
       {{- include "pulsar.broker.certs.volumes" . | nindent 6 }}
+      {{- include "pulsar.imagePullSecrets" . | nindent 6}}
 {{- end }}

charts/pulsar/templates/grafana-deployment.yaml

@@ -87,4 +87,5 @@ spec:
             secretKeyRef:
               name: "{{ template "pulsar.fullname" . }}-{{ .Values.grafana.component }}-secret"
               key: GRAFANA_ADMIN_PASSWORD
+        {{- include "pulsar.imagePullSecrets" . | nindent 6}}
 {{- end }}

charts/pulsar/templates/prometheus-deployment.yaml

@@ -93,4 +93,5 @@ spec:
         persistentVolumeClaim:
           claimName: "{{ template "pulsar.fullname" . }}-{{ .Values.prometheus.component }}-{{ .Values.prometheus.volumes.data.name }}"
     {{- end }}
+    {{- include "pulsar.imagePullSecrets" . | nindent 6}}
 {{- end }}

charts/pulsar/templates/proxy-statefulset.yaml

@@ -222,6 +222,7 @@ spec:
             readOnly: true
           {{- end}}
       {{- end}}
+      {{- include "pulsar.imagePullSecrets" . | nindent 6}}
       {{- if or .Values.auth.authentication.enabled (and .Values.tls.enabled .Values.tls.proxy.enabled) }}
       volumes:
         {{- if .Values.auth.authentication.enabled }}

charts/pulsar/templates/pulsar-manager-deployment.yaml

@@ -89,6 +89,7 @@ spec:
                 {{- else }}
                 name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}-secret"
                 {{- end }}
+        {{- include "pulsar.imagePullSecrets" . | nindent 6}}
       volumes:
         - name: pulsar-manager-data
           emptyDir: {}

charts/pulsar/templates/toolset-statefulset.yaml

@@ -115,4 +115,5 @@ spec:
               path: ca.crt
       {{- end}}
       {{- include "pulsar.toolset.certs.volumes" . | nindent 6 }}
+      {{- include "pulsar.imagePullSecrets" . | nindent 6}}
 {{- end }}