diff --git a/charts/pulsar/templates/_helpers.tpl b/charts/pulsar/templates/_helpers.tpl index c41e213..62eb046 100644 --- a/charts/pulsar/templates/_helpers.tpl +++ b/charts/pulsar/templates/_helpers.tpl @@ -128,3 +128,10 @@ Create full image name {{- define "pulsar.imageFullName" -}} {{- printf "%s:%s" (.image.repository | default .root.Values.defaultPulsarImageRepository) (.image.tag | default .root.Values.defaultPulsarImageTag | default .root.Chart.AppVersion) -}} {{- end -}} + +{{/* +Lookup pull policy, default to defaultPullPolicy +*/}} +{{- define "pulsar.imagePullPolicy" -}} +{{- printf "%s" (.image.pullPolicy | default .root.Values.defaultPullPolicy) -}} +{{- end -}} diff --git a/charts/pulsar/templates/autorecovery-statefulset.yaml b/charts/pulsar/templates/autorecovery-statefulset.yaml index bdf0311..7944580 100644 --- a/charts/pulsar/templates/autorecovery-statefulset.yaml +++ b/charts/pulsar/templates/autorecovery-statefulset.yaml @@ -110,7 +110,7 @@ spec: # before deploying the bookies - name: pulsar-bookkeeper-verify-clusterid image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.autorecovery "root" .) }}" - imagePullPolicy: {{ .Values.images.autorecovery.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.autorecovery "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -124,7 +124,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.autorecovery.component }}" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.autorecovery "root" .) }}" - imagePullPolicy: {{ .Values.images.autorecovery.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.autorecovery "root" .) }}" {{- if .Values.autorecovery.resources }} resources: {{ toYaml .Values.autorecovery.resources | indent 10 }} diff --git a/charts/pulsar/templates/bookkeeper-cluster-initialize.yaml b/charts/pulsar/templates/bookkeeper-cluster-initialize.yaml index f83ade0..fef517d 100755 --- a/charts/pulsar/templates/bookkeeper-cluster-initialize.yaml +++ b/charts/pulsar/templates/bookkeeper-cluster-initialize.yaml @@ -47,7 +47,7 @@ spec: initContainers: - name: wait-zookeeper-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.bookie "root" .) }}" - imagePullPolicy: {{ .Values.images.bookie.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.bookie "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -65,7 +65,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}-init" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.bookie "root" .) }}" - imagePullPolicy: {{ .Values.images.bookie.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.bookie "root" .) }}" {{- if .Values.bookkeeper.metadata.resources }} resources: {{ toYaml .Values.bookkeeper.metadata.resources | indent 10 }} diff --git a/charts/pulsar/templates/bookkeeper-statefulset.yaml b/charts/pulsar/templates/bookkeeper-statefulset.yaml index d34269b..a9db632 100644 --- a/charts/pulsar/templates/bookkeeper-statefulset.yaml +++ b/charts/pulsar/templates/bookkeeper-statefulset.yaml @@ -111,7 +111,7 @@ spec: # before deploying the bookies - name: pulsar-bookkeeper-verify-clusterid image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.bookie "root" .) }}" - imagePullPolicy: {{ .Values.images.bookie.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.bookie "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -130,7 +130,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.bookkeeper.component }}" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.bookie "root" .) }}" - imagePullPolicy: {{ .Values.images.bookie.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.bookie "root" .) }}" {{- if .Values.bookkeeper.probe.liveness.enabled }} livenessProbe: httpGet: diff --git a/charts/pulsar/templates/broker-configmap.yaml b/charts/pulsar/templates/broker-configmap.yaml index baac848..1f34875 100644 --- a/charts/pulsar/templates/broker-configmap.yaml +++ b/charts/pulsar/templates/broker-configmap.yaml @@ -114,6 +114,7 @@ data: PF_functionRuntimeFactoryConfigs_pulsarRootDir: {{ template "pulsar.home" . }} PF_kubernetesContainerFactory_pulsarRootDir: {{ template "pulsar.home" . }} PF_functionRuntimeFactoryConfigs_pulsarDockerImageName: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.functions "root" .) }}" + PF_functionRuntimeFactoryConfigs_imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.functions "root" .) }}" PF_functionRuntimeFactoryConfigs_submittingInsidePod: "true" PF_functionRuntimeFactoryConfigs_installUserCodeDependencies: "true" PF_functionRuntimeFactoryConfigs_jobNamespace: {{ template "pulsar.namespace" . }} @@ -127,6 +128,7 @@ data: {{- end }} # support version < 2.5.0 PF_kubernetesContainerFactory_pulsarDockerImageName: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.functions "root" .) }}" + PF_kubernetesContainerFactory_imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.functions "root" .) }}" PF_kubernetesContainerFactory_submittingInsidePod: "true" PF_kubernetesContainerFactory_installUserCodeDependencies: "true" PF_kubernetesContainerFactory_jobNamespace: {{ template "pulsar.namespace" . }} diff --git a/charts/pulsar/templates/broker-statefulset.yaml b/charts/pulsar/templates/broker-statefulset.yaml index f45adcf..edc1e97 100644 --- a/charts/pulsar/templates/broker-statefulset.yaml +++ b/charts/pulsar/templates/broker-statefulset.yaml @@ -125,7 +125,7 @@ spec: # deploying the bookies - name: wait-zookeeper-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.broker "root" .) }}" - imagePullPolicy: {{ .Values.images.broker.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.broker "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -150,7 +150,7 @@ spec: # deploying the broker - name: wait-bookkeeper-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.broker "root" .) }}" - imagePullPolicy: {{ .Values.images.broker.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.broker "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -182,7 +182,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.broker.component }}" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.broker "root" .) }}" - imagePullPolicy: {{ .Values.images.broker.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.broker "root" .) }}" {{- if .Values.broker.probe.liveness.enabled }} livenessProbe: httpGet: diff --git a/charts/pulsar/templates/proxy-statefulset.yaml b/charts/pulsar/templates/proxy-statefulset.yaml index e6a1810..01d911e 100644 --- a/charts/pulsar/templates/proxy-statefulset.yaml +++ b/charts/pulsar/templates/proxy-statefulset.yaml @@ -109,7 +109,7 @@ spec: # deploying the bookies - name: wait-zookeeper-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.proxy "root" .) }}" - imagePullPolicy: {{ .Values.images.proxy.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.proxy "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -128,7 +128,7 @@ spec: # deploying the proxy - name: wait-broker-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.proxy "root" .) }}" - imagePullPolicy: {{ .Values.images.proxy.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.proxy "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -143,7 +143,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.proxy.component }}" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.proxy "root" .) }}" - imagePullPolicy: {{ .Values.images.proxy.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.proxy "root" .) }}" {{- if .Values.proxy.probe.liveness.enabled }} livenessProbe: httpGet: diff --git a/charts/pulsar/templates/pulsar-cluster-initialize.yaml b/charts/pulsar/templates/pulsar-cluster-initialize.yaml index f24949b..1d8e101 100755 --- a/charts/pulsar/templates/pulsar-cluster-initialize.yaml +++ b/charts/pulsar/templates/pulsar-cluster-initialize.yaml @@ -44,7 +44,7 @@ spec: {{- if .Values.pulsar_metadata.configurationStore }} - name: wait-cs-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.pulsar_metadata.image "root" .) }}" - imagePullPolicy: {{ .Values.pulsar_metadata.image.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -55,7 +55,7 @@ spec: {{- end }} - name: wait-zookeeper-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.pulsar_metadata.image "root" .) }}" - imagePullPolicy: {{ .Values.pulsar_metadata.image.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -74,7 +74,7 @@ spec: # before initializing pulsar metadata - name: pulsar-bookkeeper-verify-clusterid image: "{{ template "pulsar.imageFullName" (dict "image" .Values.pulsar_metadata.image "root" .) }}" - imagePullPolicy: {{ .Values.pulsar_metadata.image.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 10 }} command: ["sh", "-c"] args: @@ -95,7 +95,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_metadata.component }}" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.pulsar_metadata.image "root" .) }}" - imagePullPolicy: {{ .Values.pulsar_metadata.image.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" {{- if .Values.pulsar_metadata.resources }} resources: {{ toYaml .Values.pulsar_metadata.resources | indent 10 }} diff --git a/charts/pulsar/templates/pulsar-manager-cluster-initialize.yaml b/charts/pulsar/templates/pulsar-manager-cluster-initialize.yaml index a5f76fc..d09b7dc 100755 --- a/charts/pulsar/templates/pulsar-manager-cluster-initialize.yaml +++ b/charts/pulsar/templates/pulsar-manager-cluster-initialize.yaml @@ -45,7 +45,7 @@ spec: initContainers: - name: wait-pulsar-manager-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.pulsar_metadata.image "root" .) }}" - imagePullPolicy: {{ .Values.pulsar_metadata.image.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 12 }} command: [ "sh", "-c" ] args: @@ -59,7 +59,7 @@ spec: {{- if .Values.components.broker }} - name: wait-broker-ready image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.proxy "root" .) }}" - imagePullPolicy: {{ .Values.images.proxy.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" resources: {{ toYaml .Values.initContainer.resources | nindent 12 }} command: [ "sh", "-c" ] args: @@ -75,7 +75,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}-init" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.pulsar_metadata.image "root" .) }}" - imagePullPolicy: {{ .Values.pulsar_metadata.image.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.pulsar_metadata.image "root" .) }}" {{- if .Values.pulsar_metadata.resources }} resources: {{ toYaml .Values.pulsar_metadata.resources | nindent 12 }} {{- end }} diff --git a/charts/pulsar/templates/pulsar-manager-statefulset.yaml b/charts/pulsar/templates/pulsar-manager-statefulset.yaml index 3b29d6f..236a82e 100755 --- a/charts/pulsar/templates/pulsar-manager-statefulset.yaml +++ b/charts/pulsar/templates/pulsar-manager-statefulset.yaml @@ -58,7 +58,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.pulsar_manager.component }}" image: "{{ .Values.images.pulsar_manager.repository }}:{{ .Values.images.pulsar_manager.tag }}" - imagePullPolicy: {{ .Values.images.pulsar_manager.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.pulsar_manager "root" .) }}" {{- if .Values.pulsar_manager.resources }} resources: {{ toYaml .Values.pulsar_manager.resources | indent 12 }} diff --git a/charts/pulsar/templates/toolset-statefulset.yaml b/charts/pulsar/templates/toolset-statefulset.yaml index 3ecd479..fe7ab7c 100644 --- a/charts/pulsar/templates/toolset-statefulset.yaml +++ b/charts/pulsar/templates/toolset-statefulset.yaml @@ -61,8 +61,13 @@ spec: serviceAccountName: "{{ template "pulsar.fullname" . }}-{{ .Values.toolset.component }}" containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.toolset.component }}" + {{- if (and .Values.images.toolset .Values.images.toolset.repository) }} + image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.toolset "root" .) }}" + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.toolset "root" .) }}" + {{- else }} image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.broker "root" .) }}" - imagePullPolicy: {{ .Values.images.broker.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.broker "root" .) }}" + {{- end }} {{- if .Values.toolset.resources }} resources: {{ toYaml .Values.toolset.resources | indent 10 }} diff --git a/charts/pulsar/templates/zookeeper-statefulset.yaml b/charts/pulsar/templates/zookeeper-statefulset.yaml index 8f0ef6e..0fb001f 100755 --- a/charts/pulsar/templates/zookeeper-statefulset.yaml +++ b/charts/pulsar/templates/zookeeper-statefulset.yaml @@ -108,7 +108,7 @@ spec: containers: - name: "{{ template "pulsar.fullname" . }}-{{ .Values.zookeeper.component }}" image: "{{ template "pulsar.imageFullName" (dict "image" .Values.images.zookeeper "root" .) }}" - imagePullPolicy: {{ .Values.images.zookeeper.pullPolicy }} + imagePullPolicy: "{{ template "pulsar.imagePullPolicy" (dict "image" .Values.images.zookeeper "root" .) }}" {{- if .Values.zookeeper.resources }} resources: {{ toYaml .Values.zookeeper.resources | indent 10 }} diff --git a/charts/pulsar/values.yaml b/charts/pulsar/values.yaml index 21cb554..581197c 100755 --- a/charts/pulsar/values.yaml +++ b/charts/pulsar/values.yaml @@ -137,6 +137,9 @@ defaultPulsarImageRepository: apachepulsar/pulsar-all # uses chart's appVersion when unspecified defaultPulsarImageTag: +# default pull policy for all images +defaultPullPolicy: IfNotPresent + ## Images ## ## Control what images to use for each component @@ -149,40 +152,55 @@ images: repository: # uses defaultPulsarImageTag when unspecified tag: - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: bookie: # uses defaultPulsarImageRepository when unspecified repository: # uses defaultPulsarImageTag when unspecified tag: - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: autorecovery: # uses defaultPulsarImageRepository when unspecified repository: # uses defaultPulsarImageTag when unspecified tag: - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: broker: # uses defaultPulsarImageRepository when unspecified repository: # uses defaultPulsarImageTag when unspecified tag: - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: + toolset: + # uses defaultPulsarImageRepository when unspecified + repository: + # uses defaultPulsarImageTag when unspecified + tag: + # uses defaultPullPolicy when unspecified + pullPolicy: proxy: # uses defaultPulsarImageRepository when unspecified repository: # uses defaultPulsarImageTag when unspecified tag: - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: functions: # uses defaultPulsarImageRepository when unspecified repository: # uses defaultPulsarImageTag when unspecified tag: + # uses defaultPullPolicy when unspecified + pullPolicy: pulsar_manager: repository: apachepulsar/pulsar-manager tag: v0.4.0 - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: hasCommand: false ## TLS @@ -726,7 +744,8 @@ pulsar_metadata: repository: # uses defaultPulsarImageTag when unspecified tag: - pullPolicy: IfNotPresent + # uses defaultPullPolicy when unspecified + pullPolicy: ## set an existing configuration store # configurationStore: configurationStoreMetadataPrefix: ""